Skip to content

Run tests on PHP 8.3 and update test suite #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2023
Merged

Run tests on PHP 8.3 and update test suite #54

merged 1 commit into from
Nov 17, 2023

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 13, 2023 •
edited
Loading

This pull request builds on top of #46, #47 and #48.

References: clue/reactphp-csv#33, reactphp/socket#300 and reactphp/socket#299.

After this pull request is merged, we can continue with #53.

SimonFrings
SimonFrings suggested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that we're still using the old ubuntu-20.04 in our PHPUnit job within the ci.yml file. I believe this should also be updated to ubuntu-22.04, just like you did for the PHPUnit-hhvm job.

@SimonFrings SimonFrings added documentation Improvements or additions to documentation new feature and removed documentation Improvements or additions to documentation labels Nov 14, 2023
@yadaiio
Copy link
Contributor Author

yadaiio commented Nov 14, 2023 •
edited
Loading

Tysm @SimonFrings for sharpening my eyes for this ! I totally didn't saw this in the first place. Whoops. But it should be alright now! 🥳

SimonFrings
SimonFrings approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes, looking good 👍

@SimonFrings SimonFrings added this to the v1.9.0 milestone Nov 14, 2023
@SimonFrings SimonFrings requested a review from clue November 14, 2023 16:05
@SimonFrings SimonFrings mentioned this pull request Nov 15, 2023
Closed
clue
clue approved these changes Nov 17, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit 4f9cf0a into clue:1.x Nov 17, 2023
This was referenced Dec 6, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

+1 more reviewer

@SimonFrings SimonFrings SimonFrings approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yadaiio @clue @SimonFrings